Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker otelsvc build. #29

Merged
merged 1 commit into from
Jun 20, 2019
Merged

fix docker otelsvc build. #29

merged 1 commit into from
Jun 20, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Jun 20, 2019

fixes #28

tigrannajaryan
tigrannajaryan approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   68.94%   68.94%           
=======================================
  Files          82       82           
  Lines        5461     5461           
=======================================
  Hits         3765     3765           
  Misses       1480     1480           
  Partials      216      216

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aac7c1...9dd33ec. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 8772c90 into open-telemetry:master Jun 20, 2019
pjanotti referenced this pull request in pjanotti/opentelemetry-service Jun 27, 2019
@songy23
Move Agent document to README. (#29)
d027b3c
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@thinkerou @rghetia
update type style (open-telemetry#29)
36f5138
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@jchengsfx
Package updates (open-telemetry#29)
389fbb1 
* Fix deb filenames for publish

* Update systemd env file for SPLUNK_BALLAST

* Rename systemd environment file

* Allow otelcol options to be configurable in env file
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
@rnburn
Add a Timestamp type (open-telemetry#29)
9df8eb6 
* Add timestamp

* Reword

* Reword

* Fix build for gcc48

* Fix cmake tests

* Update timestamp storage

* Reformat

* Split timestamp into a system and steady type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@pjanotti pjanotti pjanotti approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@flands flands Awaiting requested review from flands

Assignees

@rghetia rghetia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make docker-otelsvc fails
6 participants
@rghetia @codecov-io @bogdandrutu @tigrannajaryan @pjanotti @songy23