-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Validate() in ReceiverSettings, easy transition #2865
Conversation
@@ -334,7 +334,8 @@ func TestBuildReceivers_NotSupportedDataType(t *testing.T) { | |||
t.Run(test.configFile, func(t *testing.T) { | |||
|
|||
cfg, err := configtest.LoadConfigFile(t, path.Join("testdata", test.configFile), factories) | |||
assert.Error(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed in #2802 because NopConfig.Validate was failing because "bf" (badfactory) was not the same type as "nop"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my bad. Thx for correcting it.
Codecov Report
@@ Coverage Diff @@
## main #2865 +/- ##
==========================================
- Coverage 91.80% 91.80% -0.01%
==========================================
Files 286 286
Lines 15146 15141 -5
==========================================
- Hits 13905 13900 -5
Misses 849 849
Partials 392 392
Continue to review full report at Codecov.
|
Hi @bogdandrutu, could you help to elaborate what's the next step making I can help to make the same changes to the other components after this PR got merged. :) |
fdb0a19
to
66844e3
Compare
@mxiamxia thanks for commenting, sure we should apply the same change to all the configs (including changes from this PR):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll take over and work on the rest of configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe I should do this too for unmarshaling on #2867 (nope, not possible)
66844e3
to
b276205
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
b276205
to
4392201
Compare
…etry#2865) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
…ry#2865) * Update installer script for amazonlinux 2023 and rhel 9 * Update linux-installer.md * Update test images * Create test matrix for distros
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com