Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune logs (zap) fields for each component, remove duplicate type already in name #2864

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

…ady in name

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team March 31, 2021 01:13
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #2864 (dc8ec21) into main (2605ec4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2864   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         286      286           
  Lines       15158    15158           
=======================================
  Hits        13911    13911           
  Misses        853      853           
  Partials      394      394           
Impacted Files Coverage Δ
service/internal/builder/builder.go 100.00% <ø> (ø)
service/internal/builder/exporters_builder.go 81.73% <100.00%> (ø)
service/internal/builder/extensions_builder.go 80.76% <100.00%> (ø)
service/internal/builder/pipelines_builder.go 90.62% <100.00%> (ø)
service/internal/builder/receivers_builder.go 72.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2605ec4...dc8ec21. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 231815c into open-telemetry:main Mar 31, 2021
@bogdandrutu bogdandrutu deleted the logsprop branch March 31, 2021 15:27
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
…ady in name (open-telemetry#2864)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants