Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol/exporter/kafka: key jaeger messages on traceid #2855

Merged
merged 1 commit into from
Apr 8, 2021
Merged

otelcol/exporter/kafka: key jaeger messages on traceid #2855

merged 1 commit into from
Apr 8, 2021

Conversation

kjetijor
Copy link
Contributor

@kjetijor kjetijor commented Mar 30, 2021

Description: exporter/kafkaexporter: key jaeger spans by traceid, emulating jaeger-collector behavior. This allows for "grouping by traceid" for kafka consumers. For reference: jaeger kafka producer.

Link to tracking Issue: N/A

Testing: Updated tests, inspected resulting messages produced into kafka to match up with the expectation.

Documentation: Updated kafkaexporter documentation to reflect behavior

@kjetijor kjetijor requested a review from a team March 30, 2021 17:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2855 (9057e0a) into main (c8bc12e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         278      278           
  Lines       15432    15434    +2     
=======================================
+ Hits        14204    14206    +2     
  Misses        845      845           
  Partials      383      383           
Impacted Files Coverage Δ
exporter/kafkaexporter/marshaller.go 100.00% <ø> (ø)
exporter/kafkaexporter/jaeger_marshaller.go 86.36% <100.00%> (+0.64%) ⬆️
exporter/kafkaexporter/kafka_exporter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bc12e...9057e0a. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpkrohling
Copy link
Member

I might take a while to review this one, if any other Jaeger maintainers feel like they can review this one, I'll give my approval by proxy :-)

cc @albertteoh, @joe-elliott

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdandrutu
Copy link
Member

Is this a breaking change? Should we protect by a config flag?

@kjetijor
Copy link
Contributor Author

kjetijor commented Apr 6, 2021

@bogdandrutu

Is this a breaking change? Should we protect by a config flag?

I do not believe this to be a breaking change. While, this does affect placement of messages into kafka partitions, for all practical purposes we go from random to slightly less random.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the review from @albertteoh

@bogdandrutu bogdandrutu merged commit 714702a into open-telemetry:main Apr 8, 2021
@kjetijor kjetijor deleted the jaeger-keyed-messages-cla branch April 8, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants