Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd environment file for deb/rpm packages #2822

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

jchengsfx
Copy link
Contributor

@jchengsfx jchengsfx commented Mar 26, 2021

Description:
Include a systemd environment file in the deb/rpm packages for the otel-collector service that allows the user to configure the otelcol startup options and add custom environment variables when running the collector as a service. Default otelcol option is --config=/etc/otel-collector/config.yaml.

Link to tracking Issue:
#2255

Testing:
Tested locally and in CI.

Documentation:
open-telemetry/opentelemetry.io#500

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2822 (8efc2e7) into main (e7c74eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2822   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         290      290           
  Lines       15541    15541           
=======================================
  Hits        14242    14242           
  Misses        889      889           
  Partials      410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c74eb...8efc2e7. Read the comment docs.

Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but fix tests

@jchengsfx
Copy link
Contributor Author

LGTM but fix tests

The contrib test failures don't seem to be related to these changes. The same tests are also failing in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants