Change CustomUnmarshaler implementations to use config.Parser, prove the interface

[bogdandrutu]

Fixes #2735

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #2810 (241e46c) into main (09f29af) will increase coverage by 0.00%.
The diff coverage is 96.29%.

@@           Coverage Diff           @@
##             main    #2810   +/-   ##
=======================================
  Coverage   91.66%   91.67%           
=======================================
  Files         293      293           
  Lines       15629    15633    +4     
=======================================
+ Hits        14327    14331    +4     
+ Misses        891      890    -1     
- Partials      411      412    +1     

Impacted Files	Coverage Δ
receiver/prometheusreceiver/factory.go	82.35% <80.00%> (+0.53%)	⬆️
config/configparser/config.go	100.00% <100.00%> (ø)
config/parser.go	86.95% <100.00%> (+1.24%)	⬆️
receiver/hostmetricsreceiver/factory.go	87.01% <100.00%> (ø)
receiver/jaegerreceiver/factory.go	94.30% <100.00%> (ø)
receiver/otlpreceiver/factory.go	86.84% <100.00%> (+0.17%)	⬆️
testutil/testutil.go	81.60% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f29af...241e46c. Read the comment docs.

[bogdandrutu]

@mx-psi change the PR to not modify the CustomUnmarshaler interface yet. Reason is that I think better to just deprecate this completely.

[mx-psi]

Looks good, the PR title should be changed if we are not changing the implementations.

[mx-psi]

Reason is that I think better to just deprecate this completely.

What do you want to do instead?

[bogdandrutu]

What do you want to do instead?

Start adding this #2597 and just mark the component unmarshaler as deprecated/remove it. If I change the component unmarshaler users will first have to update to that, then remove and update to the config one so there will be 2 changes

[bogdandrutu]

Looks good, the PR title should be changed if we are not changing the implementations.

We are, because all implementation are first convert to Parser and work only on the parser interface. So now I am confident that Parser has all the functionality I need

[mx-psi]

Looks good, the PR title should be changed if we are not changing the implementations.

We are, because all implementation are first convert to Parser and work only on the parser interface. So now I am confident that Parser has all the functionality I need

Right, makes sense, let's keep it as it is then.

Start adding this #2597 and just mark the component unmarshaler as deprecated/remove it. If I change the component unmarshaler users will first have to update to that, then remove and update to the config one so there will be 2 changes

Can you have a look at the last comments on #2597 and to PR #2802 then? If you want I can work on #2597 on Monday if we agree on the interface we want (which I am guessing will be similar to the one for validation)