Move configmodels to config #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
configmodels
branch
from
1ce0ab0
to
906322c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2808 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 290 290
Lines 15541 15541
=======================================
Hits 14242 14242
Misses 889 889
Partials 410 410
Continue to review full report at Codecov.
|
|
I am not sure why we need this change. |
|
It is the only package that we use 'models'. I am trying to be consistent with components, pdata, consumer, etc. Which don't use model in their package name |
|
I also need Parser in the same package with configmodels to allow having the custom unmarshaller on the config |
tigrannajaryan
approved these changes
Mar 26, 2021
bogdandrutu
force-pushed
the
configmodels
branch
from
906322c
to
d86ea73
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
configmodels
branch
from
d86ea73
to
c983747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com