-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple OTLP to be created #2743
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
- Coverage 91.83% 91.80% -0.03%
==========================================
Files 291 291
Lines 15522 15528 +6
==========================================
+ Hits 14254 14256 +2
- Misses 867 869 +2
- Partials 401 403 +2
Continue to review full report at Codecov.
|
This test failure shouldn't be related to this change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment, the receivers are not safe to be restarted right now, and we need to define these guarantees clearly. Please start by documenting what is the requirement for each component, and think about how can we provide helpers to achieve that.
Is this still needed after #2757? If yes, change it accordingly. |
Yes, it is still needed - PR updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the last set of comments
) * Bump k8s.io/kubectl from 0.26.2 to 0.26.3 in /tests Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.26.2 to 0.26.3. - [Release notes](https://github.com/kubernetes/kubectl/releases) - [Commits](kubernetes/kubectl@v0.26.2...v0.26.3) --- updated-dependencies: - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Why
To allow the OTLP receiver to be created while one instance is already running. This allows changing the components without restarting the process. See related #2741
What
Description:
Move the registration of the receiver servers to when the receiver is started. Also check in the goroutines serving requests if the errors are not the ones expected when shutting down the receiver (avoid useless calls to ReportFatalError).
Tests:
Added tests to the otlp package to check for the issues being fixed.