Allow multiple OTLP to be created #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
- Coverage 91.83% 91.80% -0.03%
==========================================
Files 291 291
Lines 15522 15528 +6
==========================================
+ Hits 14254 14256 +2
- Misses 867 869 +2
- Partials 401 403 +2
Continue to review full report at Codecov.
|
|
This test failure shouldn't be related to this change: |
bogdandrutu
requested changes
Mar 20, 2021
|
Is this still needed after #2757? If yes, change it accordingly. |
Yes, it is still needed - PR updated. |
bogdandrutu
reviewed
Mar 22, 2021
pjanotti
commented
Mar 22, 2021
bogdandrutu
reviewed
Mar 22, 2021
bogdandrutu
approved these changes
Mar 22, 2021
bogdandrutu
approved these changes
Mar 22, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
) * Bump k8s.io/kubectl from 0.26.2 to 0.26.3 in /tests Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.26.2 to 0.26.3. - [Release notes](https://github.com/kubernetes/kubectl/releases) - [Commits](kubernetes/kubectl@v0.26.2...v0.26.3) --- updated-dependencies: - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To allow the OTLP receiver to be created while one instance is already running. This allows changing the components without restarting the process. See related #2741
What
Description:
Move the registration of the receiver servers to when the receiver is started. Also check in the goroutines serving requests if the errors are not the ones expected when shutting down the receiver (avoid useless calls to ReportFatalError).
Tests:
Added tests to the otlp package to check for the issues being fixed.