Use otlp request in wrapper, hide members in the wrapper #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
logswrapper
branch
from
b7d9a18
to
d588a51
Compare
Codecov Report
@@ Coverage Diff @@
## main #2692 +/- ##
==========================================
- Coverage 91.81% 91.80% -0.01%
==========================================
Files 290 290
Lines 15559 15551 -8
==========================================
- Hits 14285 14277 -8
Misses 876 876
Partials 398 398
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
logswrapper
branch
3 times, most recently
from
263b23f
to
b997288
Compare
Tested in contrib and was able to access InternalWrapper.Orig, with this change this is no longer possible. Also removes one extra allocation for the request object when using otlp receiver/exporter since we keep the initial pointer around. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
logswrapper
branch
from
b997288
to
cf7f4bd
Compare
tigrannajaryan
approved these changes
Mar 17, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in contrib and was able to access InternalWrapper.Orig,
with this change this is no longer possible.
Also removes one extra allocation for the request object when
using otlp receiver/exporter since we keep the initial pointer around.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com