Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied code in zipkin receiver, use the source #2484

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 13, 2021

The problem mentioned in the comment was with the thrift version, now fixed.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team February 13, 2021 18:55
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #2484 (bbb51b0) into main (5cc0707) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
+ Coverage   91.76%   91.78%   +0.01%     
==========================================
  Files         266      266              
  Lines       15112    15100      -12     
==========================================
- Hits        13867    13859       -8     
+ Misses        867      865       -2     
+ Partials      378      376       -2     
Impacted Files Coverage Δ
receiver/zipkinreceiver/trace_receiver.go 92.30% <100.00%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc0707...bbb51b0. Read the comment docs.

@tigrannajaryan
Copy link
Member

Please don't forget to include the description you put in the PR in the commit message too.

@tigrannajaryan tigrannajaryan merged commit d442d7d into open-telemetry:main Feb 17, 2021
@bogdandrutu bogdandrutu deleted the improvezip branch February 1, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants