Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached tools instead of uploading to the artifacts for the tools #2475

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Use cached tools instead of uploading to the artifacts for the tools #2475

merged 1 commit into from
Feb 18, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 12, 2021 •
edited
Loading

Updates #1234

@bogdandrutu bogdandrutu requested a review from a team February 12, 2021 21:33
@codecov
Copy link

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #2475 (bc2c23a) into main (9de6dd7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2475   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         265      265           
  Lines       15111    15111           
=======================================
  Hits        13867    13867           
  Misses        866      866           
  Partials      378      378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de6dd7...bc2c23a. Read the comment docs.

@bogdandrutu
Use cached tools instead of uploading to the artifacts
bc2c23a 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu changed the title Use cached tools instead of uploading to the artifacts Use cached tools instead of uploading to the artifacts for the tools Feb 15, 2021
@tigrannajaryan tigrannajaryan merged commit 9b2660f into open-telemetry:main Feb 18, 2021
@bogdandrutu bogdandrutu deleted the usecachedtools branch February 1, 2022 02:31
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
@meastp
[EXPORTER and SDK] Additional fixes after NOMINMAX removal on Windows (…
0134bbe 
…open-telemetry#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @tigrannajaryan