Move CombineErrors to consumererror package

[bogdandrutu]

Fixes #2472

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #2442 (4e74d79) into main (9de6dd7) will decrease coverage by 0.00%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##             main    #2442      +/-   ##
==========================================
- Coverage   91.76%   91.76%   -0.01%     
==========================================
  Files         265      266       +1     
  Lines       15111    15112       +1     
==========================================
  Hits        13867    13867              
- Misses        866      867       +1     
  Partials      378      378              

Impacted Files	Coverage Δ
component/componenterror/errors.go	0.00% <0.00%> (-100.00%)	⬇️
config/configcheck/configcheck.go	100.00% <100.00%> (ø)
consumer/consumererror/combineerrors.go	100.00% <100.00%> (ø)
exporter/kafkaexporter/jaeger_marshaller.go	85.71% <100.00%> (ø)
exporter/prometheusremotewriteexporter/exporter.go	89.26% <100.00%> (ø)
processor/cloningfanoutconnector.go	57.57% <100.00%> (ø)
processor/fanoutconnector.go	100.00% <100.00%> (ø)
receiver/jaegerreceiver/trace_receiver.go	75.49% <100.00%> (ø)
receiver/scraperhelper/errors.go	100.00% <100.00%> (ø)
receiver/scraperhelper/scrapercontroller.go	98.85% <100.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de6dd7...4e74d79. Read the comment docs.

[jpkrohling]

Is there an issue tracking this change? What's the idea behind it? I particularly find componenterror more intuitive than consumererror, but I might be missing some context here.

[bogdandrutu]

A Component is a Consumer + few extra functions. The part of the component that uses this it the Consumer, and there are other pure Consumers which use this.

[bogdandrutu]

@jpkrohling good point on the issue. I will open one explaining why some errors should be consumer some should be component. We don't have a clear logic

[bogdandrutu]

Issue created.

[tigrannajaryan]

It would help to prepare in advance a diagram of dependencies that we want to end up with to make reviewing PRs like this easier. I have a hard time keeping the desired picture in my mind.