Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max batch size for metrics #2422

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 29, 2021

During #2220 @arminru discovered that the max batch size was only applied to spans. This applies the same logic to metrics.

@dyladan dyladan requested a review from a team January 29, 2021 19:49
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #2422 (11bc205) into main (bd70c80) will decrease coverage by 0.05%.
The diff coverage is 76.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   91.93%   91.87%   -0.06%     
==========================================
  Files         269      270       +1     
  Lines       15278    15326      +48     
==========================================
+ Hits        14046    14081      +35     
- Misses        854      866      +12     
- Partials      378      379       +1     
Impacted Files Coverage Δ
processor/batchprocessor/batch_processor.go 90.08% <0.00%> (-6.38%) ⬇️
processor/batchprocessor/splitmetrics.go 94.28% <94.28%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <0.00%> (-5.41%) ⬇️
internal/data/bytesid.go 76.92% <0.00%> (-4.03%) ⬇️
exporter/otlpexporter/otlp.go 71.79% <0.00%> (-2.57%) ⬇️
internal/data/traceid.go 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd70c80...11bc205. Read the comment docs.

processor/batchprocessor/README.md Show resolved Hide resolved
processor/batchprocessor/splitmetrics.go Outdated Show resolved Hide resolved
processor/batchprocessor/splitmetrics.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit e479242 into open-telemetry:main Feb 9, 2021
@dyladan dyladan deleted the splitmetrics branch February 9, 2021 21:55
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants