Change exemplars to slice of values instead of ptrs #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 268 268
Lines 15212 15204 -8
==========================================
- Hits 13979 13971 -8
Misses 856 856
Partials 377 377
Continue to review full report at Codecov.
|
Benchmarks before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 322 3809358 ns/op 2271080 B/op 51507 allocs/op PASS ``` Benchmarks after ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 331 3594315 ns/op 3212271 B/op 34700 allocs/op PASS ``` Significant improvement in the number of allocations. Increase in the number of total bytes allocated. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
exemplarsnotnil
branch
from
389fdcf to
1fd889f
Compare
tigrannajaryan
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks before:
Benchmarks after
Significant improvement in the number of allocations. Increase in the number of total bytes allocated.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com