Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] Fix comments referencing MetricsData #2378

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 18, 2021

Description:

Link to tracking Issue: n/a

Testing: n/a this is a docs change

Documentation: Updated strings that used the old name.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #2378 (aa689df) into master (6f772bf) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
+ Coverage   92.01%   92.04%   +0.02%     
==========================================
  Files         273      273              
  Lines       15434    15426       -8     
==========================================
- Hits        14202    14199       -3     
+ Misses        850      847       -3     
+ Partials      382      380       -2     
Impacted Files Coverage Δ
consumer/pdata/metric.go 99.27% <ø> (ø)
internal/data/bytesid.go 76.92% <0.00%> (-4.03%) ⬇️
exporter/otlpexporter/otlp.go 74.35% <0.00%> (+2.56%) ⬆️
exporter/exporterhelper/metricshelper.go 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f772bf...aa689df. Read the comment docs.

@mx-psi mx-psi marked this pull request as ready for review January 18, 2021 11:12
@mx-psi mx-psi requested a review from a team January 18, 2021 11:12
@bogdandrutu bogdandrutu merged commit 79ae8f2 into open-telemetry:master Jan 19, 2021
@mx-psi mx-psi deleted the mx-psi/fix-docs branch January 19, 2021 15:58
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants