Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new semantic conventions #2365

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

willarmiros
Copy link
Contributor

Description: Updates the conventions to include new resource attributes added to the official spec in open-telemetry/opentelemetry-specification#1099 and open-telemetry/opentelemetry-specification#1112. I put the AWS attributes in here because I feel that since they're part of the official spec, they should be codified in the collector repo. But I can move them to contrib if they're strongly not wanted.

@willarmiros willarmiros requested a review from a team January 14, 2021 00:48
@willarmiros willarmiros changed the title added new semantic conventions Added new semantic conventions Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #2365 (82d7387) into master (e8cc015) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   92.00%   92.00%   -0.01%     
==========================================
  Files         272      272              
  Lines       15402    15401       -1     
==========================================
- Hits        14170    14169       -1     
  Misses        850      850              
  Partials      382      382              
Impacted Files Coverage Δ
translator/conventions/opentelemetry.go 100.00% <100.00%> (ø)
internal/data/traceid.go 84.61% <0.00%> (-7.70%) ⬇️
internal/data/spanid.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cc015...82d7387. Read the comment docs.

@willarmiros
Copy link
Contributor Author

Test failures seem to be unrelated transient issues.

@bogdandrutu
Copy link
Member

Please rebase

@willarmiros
Copy link
Contributor Author

@bogdandrutu done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants