Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-and-test GitHub Actions workflows #2319

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

shovnik
Copy link
Contributor

@shovnik shovnik commented Dec 23, 2020

Description:
This refactor PR I authored accidentally introduced an error into the build-and-test workflow which prevents the load-tests job from running altogether and fails every run of the build-and-test workflow. This one line fix should resolve the issue and allow the build-and-test workflow to pass once again.

Link to tracking Issue: #1234

Testing: Workflow was run locally and it now runs load tests as intended.

cc- @AzfaarQureshi

@shovnik shovnik requested a review from a team December 23, 2020 18:33
@shovnik
Copy link
Contributor Author

shovnik commented Dec 23, 2020

@bogdandrutu My pull request that was merged a couple days ago accidentally introduced a small error due to how I resolved merge conflicts. This one line PR needs to merged to allow load-test to run and consequently enable the build-and-test workflow to pass again.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #2319 (4ba6ea9) into master (0251103) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
- Coverage   92.02%   92.02%   -0.01%     
==========================================
  Files         273      273              
  Lines       15359    15367       +8     
==========================================
+ Hits        14134    14141       +7     
  Misses        845      845              
- Partials      380      381       +1     
Impacted Files Coverage Δ
internal/data/bytesid.go 80.95% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0251103...4ba6ea9. Read the comment docs.

@bogdandrutu bogdandrutu merged commit dc409ac into open-telemetry:master Dec 24, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…emetry#2319)

Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases)
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-xdist@v3.0.2...v3.1.0)

---
updated-dependencies:
- dependency-name: pytest-xdist
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants