Migrate CircleCI build-and-test workflow to GitHub Actions (1/3) #2291
Conversation
windows-test,check-links,setup-environment,lint,cross-compile
| GITHUB_REF=${GITHUB_REF:-} | ||
|
|
||
| diff_files="$( git diff HEAD origin/master --name-only )" | ||
| check_all_files=1 | ||
| if [[ "$GITHUB_REF" = "ref/heads/master" ]] || [[ -n "$( echo "$diff_files" | grep ".github/workflows/check-links" )" ]]; then |
There was a problem hiding this comment.
copying over the contents of .circleci/check-links/ to .github/workflows/. Needed to tweak this script so it works with the GitHub Actions environment variables and container structure
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 272 272
Lines 15284 15292 +8
==========================================
+ Hits 14068 14075 +7
Misses 837 837
- Partials 379 380 +1
Continue to review full report at Codecov.
|
AzfaarQureshi
changed the title
| { | ||
| "ignorePatterns": [ | ||
| { | ||
| "pattern": "http(s)?://\\d+\\.\\d+\\.\\d+\\.\\d+" |
There was a problem hiding this comment.
copy pasted from .circleci/check-links
.github/workflows/build-and-test.yml
Outdated
| pushd $HOME | ||
| npm install --save-dev markdown-link-check@3.8.1 | ||
| popd | ||
| - run: ./.github/workflows/check-links/check-links.sh |
There was a problem hiding this comment.
I would move this in a separate action. This should not block a release or any testing/releasing steps, only merging :)
There was a problem hiding this comment.
oh ok i see. So check_links should only be run on an open pull request?
There was a problem hiding this comment.
Can be run on master as well, but should not block other actions if possible
AzfaarQureshi
force-pushed
the
migrating-to-gha
branch
from
72e37f3 to
135ff37
Compare
|
@bogdandrutu I've separated out |
|
(its failing contrib-tests but @tigrannajaryan says thats not a blocker for collector-core PRs) |
Which problem is this solving?
As part of #1234, this pull request migrates the windows-test, setup-environment, lint, and cross-compile workflow that was contained in the config.yml file to GitHub Actions. The remaining CI jobs will be migrated in PR 2/3 and the publish jobs will be migrated in 3/3
Migration Plan
We suggest having CircleCI and GitHub Action jobs run in parallel for a few weeks. After the GitHub Actions jobs are running fine for a week or so and then remove the CircleCI workflows from config.yml
cc- @alolita, @shovnik