Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use net.SplitHostPort for IPv6 support #2154

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Use net.SplitHostPort for IPv6 support #2154

merged 1 commit into from
Nov 17, 2020

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Nov 14, 2020

No description provided.

@rakyll rakyll requested a review from a team November 14, 2020 00:29
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #2154 (4b4bf4d) into master (3e3b201) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   92.19%   92.19%   -0.01%     
==========================================
  Files         280      280              
  Lines       16981    16980       -1     
==========================================
- Hits        15655    15654       -1     
  Misses        908      908              
  Partials      418      418              
Impacted Files Coverage Δ
...eceiver/prometheusreceiver/internal/transaction.go 90.69% <33.33%> (-2.41%) ⬇️
translator/internaldata/resource_to_oc.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3b201...4b4bf4d. Read the comment docs.

@rakyll
Copy link
Contributor Author

rakyll commented Nov 17, 2020

Friendly ping.

@bogdandrutu bogdandrutu merged commit 8b68b89 into open-telemetry:master Nov 17, 2020
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants