Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default OTLP port number #2104

Conversation

tigrannajaryan
Copy link
Member

This implements specification change open-telemetry/opentelemetry-specification#1221

To make transition to new port numbers less painful OTLP receiver will
also accept data on the legacy port numbers when it is configured to
use the default endpoint. Users who use the default Collector config
can continue sending data to the legacy ports and have a graceful period
to update their senders to start sending to the new ports.

Note that OTLP/HTTP continues using a separate port number from OTLP/gRPC.
There is separate work in progress to use one port for both.

This must be merged after open-telemetry/opentelemetry-specification#1221 is merged.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2104 (b5efd85) into master (7761a6e) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
- Coverage   92.23%   92.19%   -0.04%     
==========================================
  Files         280      280              
  Lines       16977    17003      +26     
==========================================
+ Hits        15658    15676      +18     
- Misses        904      910       +6     
- Partials      415      417       +2     
Impacted Files Coverage Δ
receiver/otlpreceiver/otlp.go 85.98% <86.00%> (-6.33%) ⬇️
receiver/otlpreceiver/factory.go 86.66% <100.00%> (ø)
service/logger.go 68.42% <0.00%> (-3.01%) ⬇️
receiver/prometheusreceiver/internal/ocastore.go 91.30% <0.00%> (ø)
...er/prometheusreceiver/internal/metrics_adjuster.go 91.78% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9b7d5...2d8f1a8. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to remove the build.log

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlp-port-transition branch from dbe5792 to a4a1a4a Compare November 12, 2020 22:11
@tigrannajaryan
Copy link
Member Author

Consider to remove the build.log

Removed.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlp-port-transition branch from a4a1a4a to cfe828d Compare November 13, 2020 20:35
@tigrannajaryan
Copy link
Member Author

@open-telemetry/collector-approvers please review.

@tigrannajaryan tigrannajaryan changed the title [REVIEW BUT DONT MERGE] Change default OTLP port number Change default OTLP port number Nov 17, 2020
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlp-port-transition branch from cfe828d to b5efd85 Compare November 17, 2020 15:39
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the http default port

receiver/otlpreceiver/README.md Outdated Show resolved Hide resolved
receiver/otlpreceiver/factory.go Outdated Show resolved Hide resolved
This implements specification change open-telemetry/opentelemetry-specification#1221

To make transition to new port numbers less painful OTLP receiver will
also accept data on the legacy port numbers when it is configured to
use the default endpoint. Users who use the default Collector config
can continue sending data to the legacy ports and have a graceful period
to update their senders to start sending to the new ports.

Note that OTLP/HTTP continues using a separate port number from OTLP/gRPC.
There is separate work in progress to use one port for both.
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/otlp-port-transition branch from b5efd85 to 2d8f1a8 Compare November 18, 2020 19:46
@tigrannajaryan
Copy link
Member Author

@bogdandrutu PTAL.

@bogdandrutu bogdandrutu merged commit 29859f2 into open-telemetry:master Nov 19, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…ts (open-telemetry#2104)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@tigrannajaryan tigrannajaryan deleted the feature/tigran/otlp-port-transition branch March 3, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants