Implement Summary Metric in Prometheus RemoteWrite Exporter #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2083 +/- ##
==========================================
+ Coverage 92.10% 92.12% +0.01%
==========================================
Files 278 278
Lines 17030 17060 +30
==========================================
+ Hits 15685 15716 +31
+ Misses 924 923 -1
Partials 421 421
Continue to review full report at Codecov.
|
JasonXZLiu
changed the title
bogdandrutu
approved these changes
Nov 6, 2020
bogdandrutu
approved these changes
Nov 9, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Create a common makefile for components to be added. Use the same approach as taken by otel contrib for the main Makefile to identify sources to avoid touching component code * new timestamp processor * add timestamp to distribution * rebase Makefile * fix test * Update pkg/processor/timestamp/config.go Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * remove the need to validate +/- * add a default clause that will error out if the metric type is not supported * clean up more references to offsetFn * gofmt * remove named import * organize replace directives together * use a relative path * use timestampprocessor for the package name * move to go 1.19 * move offsetFn Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements backwards compatibility to the Prometheus Summary metric in the OTel Prometheus Remote Write Exporter. It is based off the Summary datapoint proto in this PR and the Summary implementation in this PR.
Link to tracking Issue: open-telemetry/opentelemetry-specification#1146
Testing: