Improve Clone performance by 5-7x #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` BenchmarkLogsClone-16 2022 526826 ns/op BenchmarkMetricsClone-16 92 11530154 ns/op BenchmarkTracesClone-16 237 4822875 ns/op ``` After: ``` BenchmarkLogsClone-16 17643 70484 ns/op BenchmarkMetricsClone-16 516 2226758 ns/op BenchmarkTracesClone-16 1286 853794 ns/op ``` Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
The tests that I added for clone fill all the fields, and verify all of them are "copied". In terms of reference, we do use same references to the immutable objects. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
==========================================
- Coverage 91.49% 91.49% -0.01%
==========================================
Files 282 282
Lines 16631 16628 -3
==========================================
- Hits 15217 15214 -3
Misses 978 978
Partials 436 436
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Oct 22, 2020
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
…_client`, and make it contains all symbols needed. (open-telemetry#2005) Fix open-telemetry#1998 Delegate all API calls of gRPC into `opentelemetry_exporter_otlp_grpc_client`, and make it contains all symbols needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com