Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable otlp trace by default in the released docker image #1883

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1883 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
- Coverage   91.33%   91.27%   -0.07%     
==========================================
  Files         274      274              
  Lines       16392    16392              
==========================================
- Hits        14971    14961      -10     
- Misses        993     1001       +8     
- Partials      428      430       +2     
Impacted Files Coverage Δ
...ssor/tailsamplingprocessor/idbatcher/id_batcher.go 81.81% <0.00%> (-18.19%) ⬇️
translator/internaldata/resource_to_oc.go 89.36% <0.00%> (-2.13%) ⬇️
...mplingprocessor/tailsamplingprocessor/processor.go 74.03% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aabdad...46e2c46. Read the comment docs.

@tigrannajaryan
Copy link
Member

Enable otlp trace by default in the released binaries

This does not enable anything in binary it seems. I think the file that is updated is just an example. Can you clarify?

@tigrannajaryan tigrannajaryan self-assigned this Sep 30, 2020
@bogdandrutu
Copy link
Member Author

@tigrannajaryan that file is added in the docker and used by default see https://github.com/open-telemetry/opentelemetry-collector/blob/master/cmd/otelcol/Dockerfile

@bogdandrutu bogdandrutu changed the title Enable otlp trace by default in the released binaries Enable otlp trace by default in the released docker image Sep 30, 2020
@tigrannajaryan
Copy link
Member

@tigrannajaryan that file is added in the docker and used by default see https://github.com/open-telemetry/opentelemetry-collector/blob/master/cmd/otelcol/Dockerfile

Hmm, OK, I did not realize we use it by default.

@tigrannajaryan tigrannajaryan merged commit dab0c56 into open-telemetry:master Sep 30, 2020
@bogdandrutu bogdandrutu deleted the enableotlp branch September 30, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants