Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP rec and remove qretry from example and default config #1823

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay ploffay@redhat.com

Description: <Describe what has changed.

Add OTLP receiver and qretry processor to example and default config.

Link to tracking Issue:

Updates #886
Updates #1721

Testing: < Describe what testing was performed and which tests were added.>

  • make run
  • build and run docker image

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #1823 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage   91.12%   91.10%   -0.02%     
==========================================
  Files         263      263              
  Lines       16107    16107              
==========================================
- Hits        14677    14675       -2     
- Misses       1003     1004       +1     
- Partials      427      428       +1     
Impacted Files Coverage Δ
translator/internaldata/resource_to_oc.go 87.23% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba929d...9538bd1. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigrannajaryan tigrannajaryan merged commit 64702fd into open-telemetry:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants