Authentication processor 2/4 - Add auth context and interface #1808
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
- Coverage 91.95% 91.14% -0.81%
==========================================
Files 263 265 +2
Lines 18821 16131 -2690
==========================================
- Hits 17307 14703 -2604
+ Misses 1083 1001 -82
+ Partials 431 427 -4
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-2
branch
from
f2c672e
to
2214d1e
Compare
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package auth |
There was a problem hiding this comment.
Can this file be in config/configauth/internal/?
There was a problem hiding this comment.
Only the interface, or the whole package? In any case, I would prefer to keep the config package clean from the implementation, as seems to be the case today.
There was a problem hiding this comment.
that's why I am suggesting an internal package inside the configauth which will not be exported. But this way we have localization, the current internal/auth is only used by configauth
There was a problem hiding this comment.
Except that the gRPC and HTTP receivers will use a default implementation for the interceptors/handlers, also located in this package.
There was a problem hiding this comment.
Ok, let's move forward with this (I don't believe that we cannot just have it in the internal here). But let's see.
There was a problem hiding this comment.
I'll collect the non-blocking comments in an issue, so that I can solve them in a follow-up PR. To be honest, my biggest contention right now in changing this PR is in rebasing the other two PRs again.
|
@bogdandrutu I am assigning this series to you, assuming you want to review it. |
The initialization options of the exporter are not used after the Exporter is created. Stop saving them in a field.
* Update java agent to v1.14.0 * Update smart agent to v5.22.0 * Update signalfxexporter to 05f3ece * Update changelog
Description: Added a new internal/auth package with the interface that should be implemented by authenticators. Split from #1728.
This PR is based on top of #1807.
Link to tracking Issue: Part of the solution for #1424.
Testing: unit tests.
Documentation: none.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de