Change some Prometheus remote write exporter functions to public and update link to design in README.md #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyan0
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
reviewed
Sep 1, 2020
huyan0
force-pushed
the
public
branch
2 times, most recently
from
aadbe22
to
88a9f1a
Compare
update design link
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
+ Coverage 92.37% 92.39% +0.02%
==========================================
Files 265 265
Lines 19909 19981 +72
==========================================
+ Hits 18390 18462 +72
- Misses 1090 1091 +1
+ Partials 429 428 -1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 1, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…date docs (open-telemetry#1702) * Rename WithDefaultSampler TracerProvider option to WithSampler The term "DefaultSampler" comes from early ideas of this project where there would be overriding samplers lower in the trace SDK. This overriding does not exist and if it is going to be introduced in the future the sampler associated with the TracerProvider is already scoped based on that association (no need to scope with a name). This renames the TracerProvider option to not include this anachronism. * Update PR number in CHANGELOG * Propagate rename * Update defaults documentation for TracerProvider * Update sdk/trace/provider.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update sdk/trace/provider.go Co-authored-by: Steven E. Harris <seh@panix.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following methods in the Prometheus remote write exporter to public:
prometheusremotewriteexporter.prwExporter -> PrwExporterprometheusremotewriteexporter.newExporter -> NewExporterprometheusremotewriteexporter.pushMetrics -> PushMetricprometheusremotewriteexporter.shutdown -> ShutdownThese changes allows the creation of a new exporter that use the Prometheus remote write exporter implementation.
The new exporter can have a custom configuration and factory, and pass the Prometheus remote write exporter a different http.Client that does custom authentication.
This PR also updates the link to the design PR in README.md to point to the merged DESIGN.md
Related PR: #1643
cc: @bogdandrutu @jmacd @alolita @huyan0