Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune testdata, and update testdataold to use same names #1667

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 29, 2020

Updates #1657

Split from #1666

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #1667 into master will increase coverage by 0.01%.
The diff coverage is 99.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   92.08%   92.10%   +0.01%     
==========================================
  Files         263      263              
  Lines       19216    19285      +69     
==========================================
+ Hits        17696    17763      +67     
- Misses       1106     1107       +1     
- Partials      414      415       +1     
Impacted Files Coverage Δ
internal/data/testdata/metric.go 85.50% <98.71%> (+2.41%) ⬆️
internal/dataold/testdataold/metric.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.03% <0.00%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bf8dc...8c82168. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1f7fddc into open-telemetry:master Aug 29, 2020
@bogdandrutu bogdandrutu deleted the tunetestdata branch August 29, 2020 02:31
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Bump github.com/google/go-cmp from 0.5.4 to 0.5.5

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.4 to 0.5.5.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.4...v0.5.5)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants