Move previous internal metrics package to dataold #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
==========================================
- Coverage 92.03% 92.01% -0.02%
==========================================
Files 259 260 +1
Lines 17584 17601 +17
==========================================
+ Hits 16183 16196 +13
- Misses 992 994 +2
- Partials 409 411 +2
Continue to review full report at Codecov.
|
Need to re-generate the new internal metrics, but it is too much code to change, so will move this to dataold (was internal anyway, so no public breaking change). Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
metricsinternalold
branch
from
b8fc444
to
d3054ba
Compare
dmitryax
approved these changes
Aug 28, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…en-telemetry#1662) * Fix open-telemetry#1658 SpanStatus description set only when status code is set to error * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Fixed some warnings reported by clang. -Wnewline-eof no newline at end of file -Wc++98-compat-extra-semi extra ';' outside of a function is incompatible with C++98 -Winconsistent-missing-destructor-override '~XXX' overrides a destructor but is not marked 'override' -Wheader-hygiene using namespace directive in global context in header -Wunused-parameter unused parameter Fixed some warnings reported by gcc. -Werror=missing-field-initializers missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’ -Werror=unused-variable unused variable -Werror=unused-parameter unused parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to re-generate the new internal metrics, but it is too much code to change,
so will move this to dataold (was internal anyway, so no public breaking change).
Moved internal/data to internal/dataold and metrics testdata to testdataold.
First action item from #1657