otlpreceiver: Add Log Support #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keitwb
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 90.70% 90.75% +0.05%
==========================================
Files 232 233 +1
Lines 16384 16423 +39
==========================================
+ Hits 14861 14905 +44
+ Misses 1092 1086 -6
- Partials 431 432 +1
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Jul 27, 2020
|
Did not plan to do a full review, but saw that and want to point it out :) |
bogdandrutu
reviewed
Jul 27, 2020
| require.NoError(t, err, "Failed to export trace: %v", err) | ||
| require.NotNil(t, resp, "The response is missing") | ||
|
|
||
| // assert |
There was a problem hiding this comment.
What is this comment about?
| _, port, doneFn := otlpReceiverOnGRPCServer(t, logSink) | ||
| defer doneFn() | ||
|
|
||
| traceClient, traceClientDoneFn, err := makeLogsServiceClient(port) |
| require.NoError(t, err, "Failed to create the TraceServiceClient: %v", err) | ||
| defer traceClientDoneFn() | ||
|
|
||
| // when |
|
@bogdandrutu sorry, didn't notice that you had pending comments on this. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* add OpenCensus metric exporter bridge * Update bridge/opencensus/README.md Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com> Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.