Add support for retry and sending queue for Jaeger exporter #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
- Coverage 90.61% 90.58% -0.04%
==========================================
Files 220 220
Lines 15679 15689 +10
==========================================
+ Hits 14208 14212 +4
- Misses 1059 1062 +3
- Partials 412 415 +3
Continue to review full report at Codecov.
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
retrydefault
branch
from
c8f2bc2
to
6ed0990
Compare
james-bebbington
approved these changes
Jul 21, 2020
| @@ -38,11 +38,17 @@ func NewFactory() component.ExporterFactory { | |||
| } | |||
|
|
|||
| func createDefaultConfig() configmodels.Exporter { | |||
| // TODO: Enable the queued settings. | |||
There was a problem hiding this comment.
What's the blocker for this?
There was a problem hiding this comment.
Trying to keep PRs focused, and also I need to deprecate the queue retry processor before enabling this on all the exporters
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Rename `otlp.WithAddress` to `otlp.WithEndpoint` * Unify the term of the endpoint from exporter * Update CHANGELOG * Update example/otel-collector/main.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Switch to the full word collector Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.