Update OTLP to latest version #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti and
rghetia
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 90.32% 90.39% +0.07%
==========================================
Files 218 218
Lines 15292 15419 +127
==========================================
+ Hits 13812 13938 +126
+ Misses 1071 1070 -1
- Partials 409 411 +2
Continue to review full report at Codecov.
|
tigrannajaryan
force-pushed
the
feature/tigran/updateproto
branch
from
3e5772b
to
ae9f224
Compare
- Removed the draft logsproto and now using the logs Protobufs from official OTLP repo. The rest of the changes are forced by this. - Added InstrumentationLibraryLogs and change the type of LogRecord.Body to AnyValue. - Updated fileexporter and logexporter to use the new log data type.
tigrannajaryan
force-pushed
the
feature/tigran/updateproto
branch
from
ae9f224
to
ff673d8
Compare
tigrannajaryan
changed the title
bogdandrutu
approved these changes
Jul 16, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Call otel.Handle with non-nil errors That's what normally happens in other call sites. Those two didn't check it, but passed the "error" to Handle. The default, delegating implementation of ErrorHandler was printing the error unconditionally, which resulted in pointless lines like `2020/12/07 19:51:28 <nil>` in demos, for example. * Add tests Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OTLP to latest version
official OTLP repo. The rest of the changes are forced by this.
to AnyValue.