Add device filter for file system scraper #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 218 218
Lines 15292 15311 +19
==========================================
+ Hits 13812 13829 +17
- Misses 1071 1072 +1
- Partials 409 410 +1
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
fs-device-filter
branch
from
65d03a3
to
272eb80
Compare
bogdandrutu
approved these changes
Jul 16, 2020
bogdandrutu
reviewed
Jul 16, 2020
Comment on lines
+100
to
+106
| // filter devices by name | ||
| filteredUsages := make([]*deviceUsage, 0, len(usages)) | ||
| for _, usage := range usages { | ||
| if s.includeDevice(usage.deviceName) { | ||
| filteredUsages = append(filteredUsages, usage) | ||
| } | ||
| } |
There was a problem hiding this comment.
this can be optimized:
filteredUsages := usage
s.includeFS != nil || s.excludeFS != nil {
filteredUsages := make([]*deviceUsage, 0, len(usages))
for _, usage := range usages {
if s.includeDevice(usage.deviceName) {
filteredUsages = append(filteredUsages, usage)
}
}
}
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Update core version during build During build we need to also update the core version file, otherwise, the internal metrics show "latest" instead of the real version. * Update Makefile
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.