Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate and unnecessary otlp exporter wrapper #1372

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 15, 2020

For some reasons github does not see the same diff:

[rmduplicate c66a306b] Remove duplicate and unnecessary otlp exporter wrapper
 2 files changed, 97 insertions(+), 18 deletions(-)
 rename exporter/otlpexporter/{exporter.go => otlp.go} (77%)

Steps:

  • Move push funcs to exporter.go
  • Remove unnecessary exporterImp.exportXYZ by calling directly exporterImp.w.exportXYZ from the push functions.
  • Move stop once logic to exporterImp.
  • Move New functions to the factory.
  • Move the new exporter.go -> otlp.go

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1372 into master will increase coverage by 0.01%.
The diff coverage is 70.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
+ Coverage   90.11%   90.13%   +0.01%     
==========================================
  Files         217      216       -1     
  Lines       15242    15211      -31     
==========================================
- Hits        13736    13711      -25     
+ Misses       1096     1091       -5     
+ Partials      410      409       -1     
Impacted Files Coverage Δ
exporter/otlpexporter/factory.go 78.72% <68.75%> (-21.28%) ⬇️
exporter/otlpexporter/otlp.go 69.56% <71.57%> (-2.59%) ⬇️
translator/internaldata/resource_to_oc.go 86.04% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba9cdc...90f4911. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 11e8cb0 into open-telemetry:master Jul 15, 2020
@bogdandrutu bogdandrutu deleted the rmduplicate branch September 22, 2020 21:03
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…#1372)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@7.1.0...7.1.1)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants