Remove 499 from mapping of OTel status code and HTTP #1226
Conversation
anuraaga
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
- Coverage 88.08% 88.06% -0.03%
==========================================
Files 203 203
Lines 14658 14658
==========================================
- Hits 12912 12909 -3
- Misses 1309 1310 +1
- Partials 437 439 +2
Continue to review full report at Codecov.
|
|
I might not be across other conversations on this, but should we not update the spec instead? It seems this is documented as the "official" HTTP mapping as per: https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto#L41 I actually don't know why we don't just reference that doc in the spec. |
|
Probably because this is OpenTelemetry, not Google :) Went ahead and filed open-telemetry/opentelemetry-specification#676 to see which one we want to fix. |
|
Closing since we'll update the spec instead |
…1226) * Update label.ArrayValue to store copies of 1D arrays * Update OTLP transform of array attributes * Add changes to CHANGELOG * Add PR number to changes * Update value function documentation * Remove redundant checks * Add Array test for invalid array types * Add test to ensure return from AsArray is a type * Clean up iteration
…y#1226) Bumps [boto3](https://github.com/boto/boto3) from 1.20.51 to 1.20.52. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.20.51...1.20.52) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description: <Describe what has changed.
Currently, status codes and HTTP are not mapped in a way that matches the spec. There is no mention of 499 or cancelled
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>