Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup initialization order for exporterhelper #12239

Merged
merged 1 commit into from
Feb 1, 2025

Cleanup initialization order for exporterhelper

dfa9a23
Select commit
Loading
Failed to load commit list.
Merged

Cleanup initialization order for exporterhelper #12239

Cleanup initialization order for exporterhelper
dfa9a23
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 1, 2025 in 0s

91.29% (target 90.00%)

View this Pull Request on Codecov

91.29% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 89.15663% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (5f95f72) to head (dfa9a23).

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/base_exporter.go 94.44% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/queue_sender.go 72.72% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request_sender.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12239      +/-   ##
==========================================
- Coverage   91.31%   91.29%   -0.03%     
==========================================
  Files         465      465              
  Lines       25654    25662       +8     
==========================================
+ Hits        23427    23429       +2     
- Misses       1814     1818       +4     
- Partials      413      415       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov