Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to get a metric for componentest.Telemetry #12215

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners January 30, 2025 17:24
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 64.74820% with 49 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (c119b2a) to head (b141545).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
component/componenttest/otelchecker.go 0.00% 28 Missing ⚠️
component/componenttest/telemetry.go 0.00% 11 Missing ⚠️
component/componenttest/obsreporttest.go 0.00% 10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (64.74%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12215   +/-   ##
=======================================
  Coverage   91.28%   91.29%           
=======================================
  Files         465      465           
  Lines       25616    25629   +13     
=======================================
+ Hits        23384    23397   +13     
  Misses       1819     1819           
  Partials      413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 30, 2025
Merged via the queue into open-telemetry:main with commit fb8bb93 Jan 30, 2025
52 of 53 checks passed
@bogdandrutu bogdandrutu deleted the add-get-metrics branch January 30, 2025 19:24
sfc-gh-sili pushed a commit to sfc-gh-sili/opentelemetry-collector that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants