Add helper functions for printing flags #12094
Conversation
|
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
|
@yurishkuro I have made the necessary changes. Following is how the output is coming: |
| @@ -42,6 +42,11 @@ func NewCommand(set CollectorSettings) *cobra.Command { | |||
| return rootCmd | |||
| } | |||
|
|
|||
| // Helper function for "make features" commmand for Jaeger | |||
| func FeatureCommand(set CollectorSettings) { | |||
There was a problem hiding this comment.
I don't follow. I am expecting to be able to run otelcol features
There was a problem hiding this comment.
Okay, got it. Adding changes for the subcommand for otelcol features.
I thought that only go run ./cmd/jaeger features was required.
There was a problem hiding this comment.
I am expecting to be able to run otelcol features
When I try to run otelcol features, it is saying that otelcol is not a command. How to set up the command otelcol and how to bind a function with features
There was a problem hiding this comment.
cd cmd/otelcorecol
go run . help
|
@ADI-ROXX you can copy and adapt implementation from jaegertracing/jaeger#6442 here |
on it |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Beautifies and prints the feature flags
Link to tracking issue
Fixes #11998