Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[README] links caption #11893

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[README] links caption #11893

merged 1 commit into from
Dec 15, 2024

Conversation

guspan-tanadi
Copy link
Contributor

Description

Provide caption of a link in README

Link to tracking issue

Fixes #

Testing

Documentation

@guspan-tanadi guspan-tanadi requested a review from a team as a code owner December 14, 2024 11:04
dmitryax
dmitryax approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 14, 2024
@dmitryax dmitryax enabled auto-merge December 14, 2024 23:57
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (7941703) to head (c148ec9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11893   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added this pull request to the merge queue Dec 15, 2024
Merged via the queue into open-telemetry:main with commit 5da51fa Dec 15, 2024
54 of 68 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 15, 2024
@guspan-tanadi guspan-tanadi deleted the links branch December 15, 2024 00:38
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@guspan-tanadi @HongChenTW
[README] links caption (open-telemetry#11893)
8bf0ae9 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Provide caption of a link in README
<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.116.0
Development

Successfully merging this pull request may close these issues.
2 participants
@guspan-tanadi @dmitryax