Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: use ErrorContains with testify #11680

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

use ErrorContains with testify when possible

@mmorel-35 mmorel-35 requested a review from a team as a code owner November 14, 2024 19:57
@mmorel-35 mmorel-35 requested a review from codeboten November 14, 2024 19:57
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testify/error-contains branch from 49e1a70 to 6d14bce Compare November 14, 2024 19:58
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (c5a69c2) to head (6d14bce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11680   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         442      442           
  Lines       23746    23746           
=======================================
  Hits        21761    21761           
  Misses       1616     1616           
  Partials      369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit 51d57f0 into open-telemetry:main Nov 14, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2024
@mmorel-35 mmorel-35 deleted the testify/error-contains branch November 14, 2024 20:33
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
#### Description

use ErrorContains with testify when possible

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
#### Description

use ErrorContains with testify when possible

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants