Add local module replacement to ocb template #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11653 +/- ##
==========================================
+ Coverage 91.58% 91.61% +0.02%
==========================================
Files 440 440
Lines 23768 23746 -22
==========================================
- Hits 21769 21755 -14
+ Misses 1627 1620 -7
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. |
jackgopack4
force-pushed
the
add-local-replace-providers-converters
branch
from
4066e12 to
fcf78ba
Compare
|
for some reason ad8ab82 is still pending for removal even though I force pushed. |
|
if the commit doesn't disappear today I'll close this PR and open a new one with a fresh branch. opened a ticket with GitHub because this is weird behavior |
|
ok I just re-added and then reverted the commit, seems to be fine now |
bogdandrutu
reviewed
Nov 13, 2024
Comment on lines
37
to
42
| {{- range .Providers}} | ||
| {{if ne .Path ""}}replace {{.GoMod}} => {{.Path}}{{end}} | ||
| {{- end}} | ||
| {{- range .Converters}} | ||
| {{if ne .Path ""}}replace {{.GoMod}} => {{.Path}}{{end}} | ||
| {{- end}} |
There was a problem hiding this comment.
Can you do a separate PR and rename .Providers -> .ConfmapProviders same for converter?
There was a problem hiding this comment.
yeah that makes sense to me
There was a problem hiding this comment.
do you want to wait to merge this one in until that PR is open? seems like it would make sense to merge this and then I can create a new branch from main with this included
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 14, 2024
…ers (#11678) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description change name in templates and cmd/builder to refer to Providers and Converters as ConfmapProviders and ConfmapConverters <!-- Issue number if applicable --> #### Link to tracking issue as requested here: #11653 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing existing tests should cover this <!--Describe the documentation added.--> #### Documentation none, internal change and no new code/api <!--Please delete paragraphs that you did not use before submitting.-->
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds ability to replace Providers and Converters with local paths when building custom collector in ocb <!-- Issue number if applicable --> #### Link to tracking issue Closes open-telemetry#11649 <!--Describe what testing was performed and which tests were added.--> #### Testing local build of ocb with locally downloaded converter and provider (can add this type of test to github actions if others think it is necessary) <!--Describe the documentation added.--> #### Documentation .chloggen file <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…ers (open-telemetry#11678) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description change name in templates and cmd/builder to refer to Providers and Converters as ConfmapProviders and ConfmapConverters <!-- Issue number if applicable --> #### Link to tracking issue as requested here: open-telemetry#11653 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing existing tests should cover this <!--Describe the documentation added.--> #### Documentation none, internal change and no new code/api <!--Please delete paragraphs that you did not use before submitting.-->
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds ability to replace Providers and Converters with local paths when building custom collector in ocb <!-- Issue number if applicable --> #### Link to tracking issue Closes open-telemetry#11649 <!--Describe what testing was performed and which tests were added.--> #### Testing local build of ocb with locally downloaded converter and provider (can add this type of test to github actions if others think it is necessary) <!--Describe the documentation added.--> #### Documentation .chloggen file <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ers (open-telemetry#11678) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description change name in templates and cmd/builder to refer to Providers and Converters as ConfmapProviders and ConfmapConverters <!-- Issue number if applicable --> #### Link to tracking issue as requested here: open-telemetry#11653 (comment) <!--Describe what testing was performed and which tests were added.--> #### Testing existing tests should cover this <!--Describe the documentation added.--> #### Documentation none, internal change and no new code/api <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to replace Providers and Converters with local paths when building custom collector in ocb
Link to tracking issue
Closes #11649
Testing
local build of ocb with locally downloaded converter and provider (can add this type of test to github actions if others think it is necessary)
Documentation
.chloggen file