Add UnmarshalText for StabilityLevel #11520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
stabilityunmarshal
branch
from
d0317ec
to
7bb4ae6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11520 +/- ##
==========================================
+ Coverage 91.36% 91.40% +0.03%
==========================================
Files 434 434
Lines 23659 23655 -4
==========================================
+ Hits 21616 21621 +5
+ Misses 1666 1658 -8
+ Partials 377 376 -1 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
stabilityunmarshal
branch
from
7bb4ae6
to
93e62e7
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
stabilityunmarshal
branch
from
93e62e7
to
bbf982a
Compare
songy23
approved these changes
Oct 23, 2024
codeboten
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also starts using the fact that StabilityLevel implements UnmarshalText and cleans up the mdatagen stability structure.