Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cmd/builder documentation for docker image #11234

Merged

Conversation

jackgopack4
Copy link
Contributor

Description

Adding documentation for corresponding PR #671 in opentelemetry-collector-releases

Link to tracking issue

Closes #5712

Testing

Github Actions and releases in personal fork, github.com/jackgopack4/opentelemetry-collector-releases

Documentation

updates to cmd/builder/README.md for OCB instructions and docs/release.md for an automation that I also added in the releases PR

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (368cdd0) to head (82f5c5b).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11234      +/-   ##
==========================================
+ Coverage   91.44%   91.52%   +0.08%     
==========================================
  Files         424      424              
  Lines       20182    20222      +40     
==========================================
+ Hits        18456    18509      +53     
+ Misses       1342     1329      -13     
  Partials      384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jackgopack4 and others added 2 commits September 25, 2024 14:59
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
.chloggen/jackgopack4_add-ocb-docker-images.yaml Outdated Show resolved Hide resolved
cmd/builder/README.md Outdated Show resolved Hide resolved
cmd/builder/README.md Outdated Show resolved Hide resolved
docs/release.md Show resolved Hide resolved
jackgopack4 and others added 2 commits September 26, 2024 10:58
update tag references in doc

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 3de2590 into open-telemetry:main Sep 28, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 28, 2024
andrzej-stencel added a commit that referenced this pull request Oct 7, 2024
mx-psi pushed a commit that referenced this pull request Oct 7, 2024
…ge" (#11379)

Reverts #11234

The PR to publish container images for builder
open-telemetry/opentelemetry-collector-releases#671
has not been merged yet (neither has the one adding "Update version"
workflow
open-telemetry/opentelemetry-collector-releases#684).
We should only publish these docs after the images are published.

Fixes
#11347
jackgopack4 added a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding documentation for corresponding [PR open-telemetry#671 in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671)

<!-- Issue number if applicable -->
#### Link to tracking issue
Closes open-telemetry#5712 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Github Actions and releases in personal fork,
github.com/jackgopack4/opentelemetry-collector-releases

<!--Describe the documentation added.-->
#### Documentation
updates to cmd/builder/README.md for OCB instructions and
docs/release.md for an automation that I also added in the releases PR
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ocb Docker image
4 participants