Add mdatagen replace option to check-contrib target #11223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
codeboten
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11223 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 424 424
Lines 20182 20182
=======================================
Hits 18456 18456
Misses 1342 1342
Partials 384 384 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Sep 20, 2024
codeboten
approved these changes
Sep 25, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…1223) #### Description This PR addresses the issue of contrib tests not testing the updated mdatagen version. It modifies the `check-contrib` and `restore-contrib` targets in the Makefile to ensure that the contrib tests use the local version of the `mdatagen` package. #### Link to tracking issue Fixes open-telemetry#11167 #### Testing All existing tests pass with `make test` Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of contrib tests not testing the updated mdatagen version. It modifies the
check-contribandrestore-contribtargets in the Makefile to ensure that the contrib tests use the local version of themdatagenpackage.Link to tracking issue
Fixes #11167
Testing
All existing tests pass with
make test