[chore]: enable len and empty rules from testifylint #11021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/len
branch
from
2394d21 to
e27ea1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11021 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 414 414
Lines 19728 19728
=======================================
Hits 18193 18193
Misses 1165 1165
Partials 370 370 ☔ View full report in Codecov by Sentry. |
songy23
reviewed
Aug 30, 2024
There was a problem hiding this comment.
This PR enables len rule from testifylint
I don't see .golangci.yml being changed, is it missed out?
mmorel-35
force-pushed
the
testifylint/len
branch
from
573f3f1 to
1bbbf03
Compare
|
You're right, I did it on the Makefile.common but not the golangci config file |
songy23
approved these changes
Aug 30, 2024
mmorel-35
force-pushed
the
testifylint/len
branch
3 times, most recently
from
67afab1 to
66adcd2
Compare
bogdandrutu
reviewed
Sep 4, 2024
mmorel-35
force-pushed
the
testifylint/len
branch
6 times, most recently
from
40f908a to
ae0f898
Compare
mmorel-35
changed the title
mmorel-35
force-pushed
the
testifylint/len
branch
from
ae0f898 to
b3736f6
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/len
branch
from
b3736f6 to
5e0fec0
Compare
iblancasa
approved these changes
Sep 9, 2024
bogdandrutu
approved these changes
Sep 9, 2024
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector
that referenced
this pull request
Sep 10, 2024
…11021) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [len](https://github.com/Antonboom/testifylint?tab=readme-ov-file#len) and [empty](https://github.com/Antonboom/testifylint?tab=readme-ov-file#empty) rules from [testifylint](https://github.com/Antonboom/testifylint) It also adds testifylint as tool to use with a make command Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables len and empty rules from testifylint
It also adds testifylint as tool to use with a make command