[chore] add profiles support to connector receiver builder #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10956 +/- ##
==========================================
+ Coverage 91.80% 92.07% +0.26%
==========================================
Files 412 412
Lines 19357 19448 +91
==========================================
+ Hits 17770 17906 +136
+ Misses 1224 1173 -51
- Partials 363 369 +6 ☔ View full report in Codecov by Sentry. |
dmathieu
changed the title
dmathieu
force-pushed
the
connector-receiver-builder
branch
2 times, most recently
from
837cb4f
to
37f7614
Compare
dmathieu
force-pushed
the
connector-receiver-builder
branch
from
37f7614
to
f7000eb
Compare
mx-psi
approved these changes
Aug 30, 2024
mx-psi
added a commit
that referenced
this pull request
Sep 3, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follows #10956, needed for open-telemetry/opentelemetry-collector-contrib#34956 Before #10956, the `connectorprofiles` main packages was named `connector`, so this was causing a conflict with the actual `connector` module. This is not a problem in core because of the `replace`s, but it is a problem in contrib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows building profiles in the connector builder.
As this is only changing internal modules, I am marking it as chore (and skipping changelog entry).
Link to tracking issue
#10375
cc @mx-psi