[chore] set default transport defaults on NewDefaultClientConfig #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10688 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 406 406
Lines 18987 18991 +4
=======================================
+ Hits 17400 17404 +4
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jul 22, 2024
atoulme
force-pushed
the
add_defaults_to_confighttp
branch
from
9cd98e4 to
72346af
Compare
mx-psi
approved these changes
Aug 1, 2024
|
There's some errors in the |
TylerHelmuth
approved these changes
Aug 7, 2024
|
open-telemetry/opentelemetry-collector-contrib#34477 is open to unblock. |
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 7, 2024
|
MovieStoreGuy
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 9, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the defaults on
NewDefaultClientConfig. This change is a no-op since those defaults are set if the value is not set.Add documentation to all fields as well.
Link to tracking issue
#9478