-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Fix bug where expand didn't honor escaping #10560
[confmap] Fix bug where expand didn't honor escaping #10560
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10560 +/- ##
==========================================
+ Coverage 92.33% 92.35% +0.01%
==========================================
Files 393 395 +2
Lines 18647 18682 +35
==========================================
+ Hits 17218 17253 +35
Misses 1069 1069
Partials 360 360 ☔ View full report in Codecov by Sentry. |
@TylerHelmuth would you happen to know how I can identify if I am affected by this? I assumed something like the following would be problematic but it doesn't appear to be transform/redact_sensitive_information:
error_mode: ignore
log_statements:
- context: log
statements:
- replace_all_patterns(attributes, "value", "Bearer ey.*", "$$1<redacted>")
- replace_pattern(body, "Bearer ey.*", "$$1<redacted>") I have quite a few more uses of |
…lemetry-collector#10560" This reverts commit fa4f899.
Description
When we promoted
confmap.unifyEnvVarExpansion
to beta, we found that the new expansion logic inconfmap
wasn't handling escaping of$$
like it is supposed to. This PR fixes that bug, but adding escaping logic for$$
.@azunna1 this fixes the bug you mentioned in #10435 around the metricstransformprocessor:
Testing
Added new unit tests explicitly for escaping logic