Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Span.TraceState() in debugexporter #10421

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 17, 2024

Description

Span.TraceState() is not printed, but is a part of the OTel span data model.

Link to tracking issue

Part of
open-telemetry/opentelemetry-collector-contrib#31918

Testing

Documentation

n/a

@jmacd jmacd requested review from a team and atoulme June 17, 2024 22:19
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (9bd581b) to head (af301cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10421   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         386      386           
  Lines       18370    18372    +2     
=======================================
+ Hits        16965    16967    +2     
  Misses       1052     1052           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@codeboten codeboten merged commit 149ded2 into open-telemetry:main Jun 19, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants