-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confighttp] Add support for cookies #10176
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10176 +/- ##
==========================================
- Coverage 92.56% 92.39% -0.17%
==========================================
Files 387 387
Lines 18254 18329 +75
==========================================
+ Hits 16896 16935 +39
- Misses 1014 1047 +33
- Partials 344 347 +3 ☔ View full report in Codecov by Sentry. |
@mx-psi are we good to go? |
I'd like to have more context on what the use cases for this are. I think no further code changes are necessary, but I also want to know why we are doing this. |
This is useful for load balancers relying on cookies for sticky session management. See https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-sticky-sessions.html for example. Note this is used in particular when exporting data from the collector. In my case I need this for Splunk HEC support. |
Description
Add support for cookies in HTTP clients with
cookies::enabled
.Link to tracking issue
Fixes #10175
Testing
Unit test
Documentation
Added to README