Declare span statuses as constants in the pdata #851
Comments
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this issue
Nov 11, 2021
fixes open-telemetry#851 This includes all of the associated methods, such as AsUint64, AsUint64Atomic, AsUint64Ptr, CoerceToUint64, SetUint64 SetUint64Atomic, SwapUint64, SwapUint64Atomic, AddUint64, AddUint64Atomic, CompamreAndSwapUint64, CompareUint64 Only significant change as a result was converting the histogram aggregator's `count` state field into an int64 from a `metric.Number`. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this issue
Oct 9, 2024
…r threshold (open-telemetry#851) * charts/opentelemetry-collector: fix CPU limit While "256m" is a valid setting, the intention was likely to allow 4 pods to be scheduled on a single CPU, which we will currently overshoot by 24/1000, since there are only 1000 units in a CPU fraction. Adjust to "250m", which would allow exactly 4 pods to share a CPU. See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu * Update charts/opentelemetry-collector/values.yaml Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we have to use wrapped OTLP span status constants:
pdata.StatusCode(otlptrace.Status_NotFound).We need to define constants in pdata for span statuses to have something like
pdata.StatusCodeNotFoundinsteadThe text was updated successfully, but these errors were encountered: